Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ScriptsMiddleware(#15629) #16876

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonaldDWebster
Copy link

@DonaldDWebster DonaldDWebster commented Oct 13, 2024

Fixes #15629

What is your input on what else to change? Thank you for the help.

Copy link
Contributor

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

If you like Orchard Core, please star our repo and join our community channels.

@DonaldDWebster
Copy link
Author

@dotnet-policy-service agree

@dotnet-policy-service agree

@hishamco
Copy link
Member

@DonaldDWebster what's the problem you are trying to solve or fix?

@DonaldDWebster
Copy link
Author

@DonaldDWebster what's the problem you are trying to solve or fix?

I am trying to replace the middleware for the facebook & liquid modules for performance as part of issue #15629

@hishamco
Copy link
Member

I linked the issues in the description check #16876 (comment)

Please fix the build

@hishamco
Copy link
Member

Click the "Ready for Review" button once your PR is ready fro review

@DonaldDWebster
Copy link
Author

I linked the issues in the description check #16876 (comment)

Please fix the build

I’ve made the necessary fix and pushed the changes. It seems the workflow now requires your approval before it can run. If you could kindly approve the workflow at your convenience, that would be great. Thank you for the help today.

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ScriptsMiddleware(s) should be replaced by endpoints
2 participants